Feature/complete port of esr js #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EOS-Nation/dart-esr into feature/complete-port-of-esr-js
…this package on pub dev)
|
This is amazing, let's merge it, but maybe moving zlib to separate package? |
Open
I agree zlib shouldn't be in the same package. Normally, it would use the archive package but it is missing zlib raw feature. I did a pull request with the changes but I haven't heard back from them, so I put it in the dart-esr package because I didn't want to duplicate archive package in pub dev and it was the simplest option. But I could create another package named zlib_raw or something like that and reference it instead. wouldn't be to hard to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.